fix: filter request parameters #14
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There is a problem with the Gemini CLI PR review. Please check the action logs for details. |
andrew-waters
approved these changes
Oct 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request refactors filter-related parameters and expressions across several request classes to improve naming consistency and simplify filter usage. The main changes include renaming the
filterOptionsparameter tofiltersthroughout the codebase and updating theFieldFilterExpressionto accept a single value instead of a list. Related tests have been updated accordingly.Parameter Renaming and Consistency:
filterOptionsparameter tofiltersin all relevant request parameter classes, such asRequestParameters,RequestParametersWithIncludes, and their subclasses (e.g.,EquipmentRequestParameters,VehicleRequestParameters, etc.), to improve naming consistency. All constructor usages and superclass calls were updated to match. [1] [2] [3] [4] [5] [6] [7]Filter Expression Simplification:
FieldFilterExpressionto accept a singlevalue: Stringinstead of a list of values, and updated itsformat()method to reflect this change.Test Updates:
FieldFilterExpressioninRequestParametersFiltersTestto use a single value, and replacedfilterOptionswithfiltersin test parameter construction to align with the new API. [1] [2] [3]